[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 6/6] target/s390x: Fix brace Werror with clang 6.0.0
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 6/6] target/s390x: Fix brace Werror with clang 6.0.0 |
Date: |
Mon, 14 May 2018 17:41:14 +0200 |
From: Richard Henderson <address@hidden>
The warning is
target/s390x/misc_helper.c:209:21: error: suggest
braces around initialization of subobject [-Werror,-Wmissing-braces]
SysIB sysib = { 0 };
^
{}
While the original code is correct, and technically exactly correct
as per ISO C89, both GCC and Clang support plain empty set of braces
as an extension.
Cc: Alexander Graf <address@hidden>
Cc: David Hildenbrand <address@hidden>
Cc: Cornelia Huck <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
target/s390x/misc_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index e0b23c1fd1..1f834f35ef 100644
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -206,7 +206,7 @@ uint32_t HELPER(stsi)(CPUS390XState *env, uint64_t a0,
uint64_t r0, uint64_t r1)
const MachineState *ms = MACHINE(qdev_get_machine());
uint16_t total_cpus = 0, conf_cpus = 0, reserved_cpus = 0;
S390CPU *cpu = s390_env_get_cpu(env);
- SysIB sysib = { 0 };
+ SysIB sysib = { };
int i, cc = 0;
if ((r0 & STSI_R0_FC_MASK) > STSI_R0_FC_LEVEL_3) {
--
2.14.3
- [qemu-s390x] [PULL 0/6] s390x fixes/cleanups, Cornelia Huck, 2018/05/14
- [qemu-s390x] [PULL 2/6] pc-bios/s390-ccw: struct tpi_info must be declared as aligned(4), Cornelia Huck, 2018/05/14
- [qemu-s390x] [PULL 1/6] s390x/css: disabled subchannels cannot be status pending, Cornelia Huck, 2018/05/14
- [qemu-s390x] [PULL 3/6] virtio-ccw: common reset handler, Cornelia Huck, 2018/05/14
- [qemu-s390x] [PULL 4/6] s390x/ccw: make sure all ccw devices are properly reset, Cornelia Huck, 2018/05/14
- [qemu-s390x] [PULL 6/6] target/s390x: Fix brace Werror with clang 6.0.0,
Cornelia Huck <=
- [qemu-s390x] [PULL 5/6] s390x: refactor reset/reipl handling, Cornelia Huck, 2018/05/14
- Re: [qemu-s390x] [PULL 0/6] s390x fixes/cleanups, Peter Maydell, 2018/05/14