Re: [qemu-s390x] [PATCH 2/2] vfio-ccw: remove orb.c64 (64 bit data addresses) check

[Cornelia Huck]

On Thu, 10 May 2018 02:07:12 +0200
Halil Pasic <address@hidden> wrote:

> The vfio-ccw module does the check too, and there is actually no
> technical obstacle for supporting fmt 1 idaws. Let us be ready for the
> beautiful day when fmt 1 idaws become supported by the vfio-ccw kernel
> module. QEMU does not have to do a thing for that, except not insisting
> on this check.

Yes, it makes sense to defer failing this to the kernel module.

> 
> Signed-off-by: Halil Pasic <address@hidden>
> Acked-by: Jason J. Herne <address@hidden>
> Tested-by: Jason J. Herne <address@hidden>
> ---
>  hw/s390x/css.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index 32f1b2820d..1554b4c2f5 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -1191,17 +1191,6 @@ static IOInstEnding 
> sch_handle_start_func_passthrough(SubchDev *sch)
>          assert(orb != NULL);
>          p->intparm = orb->intparm;
>      }
> -
> -    /*
> -     * Only support prefetch enable mode.
> -     * Only support 64bit addressing idal.
> -     */
> -    if (!(orb->ctrl0 & ORB_CTRL0_MASK_C64)) {
> -        warn_report("vfio-ccw requires PFCH and C64 flags set");

Ah, here you remove the message I complained about in the last patch :)

> -        sch_gen_unit_exception(sch);
> -        css_inject_io_interrupt(sch);
> -        return IOINST_CC_EXPECTED;
> -    }
>      return s390_ccw_cmd_request(sch);
>  }
>