[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 06/28] target/tilegx: avoid integer overflow in next_
From: |
Richard Henderson |
Subject: |
[qemu-s390x] [PULL 06/28] target/tilegx: avoid integer overflow in next_page PC check |
Date: |
Wed, 9 May 2018 10:54:36 -0700 |
From: "Emilio G. Cota" <address@hidden>
If the PC is in the last page of the address space, next_page_start
overflows to 0. Fix it.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/tilegx/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/tilegx/translate.c b/target/tilegx/translate.c
index d63bf5bba3..6c53c5e767 100644
--- a/target/tilegx/translate.c
+++ b/target/tilegx/translate.c
@@ -2375,7 +2375,7 @@ void gen_intermediate_code(CPUState *cs, struct
TranslationBlock *tb)
DisasContext ctx;
DisasContext *dc = &ctx;
uint64_t pc_start = tb->pc;
- uint64_t next_page_start = (pc_start & TARGET_PAGE_MASK) +
TARGET_PAGE_SIZE;
+ uint64_t page_start = pc_start & TARGET_PAGE_MASK;
int num_insns = 0;
int max_insns = tb_cflags(tb) & CF_COUNT_MASK;
@@ -2415,7 +2415,7 @@ void gen_intermediate_code(CPUState *cs, struct
TranslationBlock *tb)
}
dc->pc += TILEGX_BUNDLE_SIZE_IN_BYTES;
if (num_insns >= max_insns
- || dc->pc >= next_page_start
+ || (dc->pc - page_start >= TARGET_PAGE_SIZE)
|| tcg_op_buf_full()) {
/* Ending the TB due to TB size or page boundary. Set PC. */
tcg_gen_movi_tl(cpu_pc, dc->pc);
--
2.17.0
- [qemu-s390x] [PULL 00/28] Bulk target patches, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 01/28] target/riscv: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 02/28] target/cris: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 03/28] target/lm32: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 04/28] target/xtensa: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 06/28] target/tilegx: avoid integer overflow in next_page PC check,
Richard Henderson <=
- [qemu-s390x] [PULL 05/28] target/unicore32: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 07/28] target/microblaze: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 09/28] target/s390x: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 08/28] target/arm: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 10/28] target/mips: avoid integer overflow in next_page PC check, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 11/28] translator: merge max_insns into DisasContextBase, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 12/28] target/sh4: convert to TranslatorOps, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 13/28] target/sparc: convert to DisasJumpType, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 16/28] target/mips: use lookup_and_goto_ptr on BS_STOP, Richard Henderson, 2018/05/09
- [qemu-s390x] [PULL 14/28] target/sparc: convert to DisasContextBase, Richard Henderson, 2018/05/09