[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 14/15] s390-ccw: force diag 308 subcode to unsigned l
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 14/15] s390-ccw: force diag 308 subcode to unsigned long |
Date: |
Fri, 4 May 2018 09:25:13 +0200 |
We currently pass an integer as the subcode parameter. However,
the upper bits of the register containing the subcode need to
be 0, which is not guaranteed unless we explicitly specify the
subcode to be an unsigned long value.
Fixes: d046c51dad3 ("pc-bios/s390-ccw: Get device address via diag 308/6")
Cc: address@hidden
Signed-off-by: Cornelia Huck <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
Tested-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
pc-bios/s390-ccw/iplb.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/iplb.h b/pc-bios/s390-ccw/iplb.h
index 5357a36d51..ded20c834e 100644
--- a/pc-bios/s390-ccw/iplb.h
+++ b/pc-bios/s390-ccw/iplb.h
@@ -101,10 +101,11 @@ static inline bool manage_iplb(IplParameterBlock *iplb,
bool store)
{
register unsigned long addr asm("0") = (unsigned long) iplb;
register unsigned long rc asm("1") = 0;
+ unsigned long subcode = store ? 6 : 5;
asm volatile ("diag %0,%2,0x308\n"
: "+d" (addr), "+d" (rc)
- : "d" (store ? 6 : 5)
+ : "d" (subcode)
: "memory", "cc");
return rc == 0x01;
}
--
2.14.3
- Re: [qemu-s390x] [Qemu-devel] [PULL 08/15] pc-bios/s390-ccw: fix loadparm initialization and int conversion, (continued)
[qemu-s390x] [PULL 09/15] pc-bios/s390-ccw: fix non-sequential boot entries (eckd), Cornelia Huck, 2018/05/04
[qemu-s390x] [PULL 10/15] pc-bios/s390-ccw: fix non-sequential boot entries (enum), Cornelia Huck, 2018/05/04
[qemu-s390x] [PULL 11/15] pc-bios/s390-ccw/net: Split up net_load() into init, load and release parts, Cornelia Huck, 2018/05/04
[qemu-s390x] [PULL 13/15] pc-bios/s390-ccw/net: Add support for .INS config files, Cornelia Huck, 2018/05/04
[qemu-s390x] [PULL 12/15] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS, Cornelia Huck, 2018/05/04
[qemu-s390x] [PULL 14/15] s390-ccw: force diag 308 subcode to unsigned long,
Cornelia Huck <=
[qemu-s390x] [PULL 15/15] pc-bios/s390: Update firmware images, Cornelia Huck, 2018/05/04
Re: [qemu-s390x] [PULL 00/15] first s390x update for 2.13, Peter Maydell, 2018/05/04