[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL SUBSYSTEM s390x 01/10] pc-bios/s390-ccw: size_t shoul
From: |
Thomas Huth |
Subject: |
[qemu-s390x] [PULL SUBSYSTEM s390x 01/10] pc-bios/s390-ccw: size_t should be unsigned |
Date: |
Wed, 2 May 2018 16:33:20 +0200 |
"size_t" should be an unsigned type according to the C standard.
Thus we should also use this convention in the s390-ccw firmware to avoid
confusion. I checked the sources, and apart from one spot in libc.c, the
code should all be fine with this change.
Buglink: https://bugs.launchpad.net/qemu/+bug/1753437
Reviewed-by: Christian Borntraeger <address@hidden>
Reviewed-by: Halil Pasic <address@hidden>
Reviewed-by: Collin Walling <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
pc-bios/s390-ccw/libc.c | 2 +-
pc-bios/s390-ccw/libc.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/pc-bios/s390-ccw/libc.c b/pc-bios/s390-ccw/libc.c
index 38ea77d..a786566 100644
--- a/pc-bios/s390-ccw/libc.c
+++ b/pc-bios/s390-ccw/libc.c
@@ -63,7 +63,7 @@ uint64_t atoui(const char *str)
*/
char *uitoa(uint64_t num, char *str, size_t len)
{
- size_t num_idx = 1; /* account for NUL */
+ long num_idx = 1; /* account for NUL */
uint64_t tmp = num;
IPL_assert(str != NULL, "uitoa: no space allocated to store string");
diff --git a/pc-bios/s390-ccw/libc.h b/pc-bios/s390-ccw/libc.h
index 63ece70..818517f 100644
--- a/pc-bios/s390-ccw/libc.h
+++ b/pc-bios/s390-ccw/libc.h
@@ -12,7 +12,7 @@
#ifndef S390_CCW_LIBC_H
#define S390_CCW_LIBC_H
-typedef long size_t;
+typedef unsigned long size_t;
typedef int bool;
typedef unsigned char uint8_t;
typedef unsigned short uint16_t;
--
1.8.3.1
- [qemu-s390x] [PULL SUBSYSTEM s390x 00/10] s390-ccw firmware update - not for master, Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 01/10] pc-bios/s390-ccw: size_t should be unsigned,
Thomas Huth <=
- [qemu-s390x] [PULL SUBSYSTEM s390x 04/10] pc-bios/s390-ccw: fix non-sequential boot entries (eckd), Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 02/10] pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES, Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 03/10] pc-bios/s390-ccw: fix loadparm initialization and int conversion, Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 08/10] pc-bios/s390-ccw/net: Add support for .INS config files, Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 05/10] pc-bios/s390-ccw: fix non-sequential boot entries (enum), Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 09/10] s390-ccw: force diag 308 subcode to unsigned long, Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 06/10] pc-bios/s390-ccw/net: Split up net_load() into init, load and release parts, Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 07/10] pc-bios/s390-ccw/net: Use diag308 to reset machine before jumping to the OS, Thomas Huth, 2018/05/02
- [qemu-s390x] [PULL SUBSYSTEM s390x 10/10] pc-bios/s390: Update firmware images, Thomas Huth, 2018/05/02
- Re: [qemu-s390x] [PULL SUBSYSTEM s390x 00/10] s390-ccw firmware update - not for master, Cornelia Huck, 2018/05/03