[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH 1/3] exec: fix memory leak in find_max_supported
From: |
Thomas Huth |
Subject: |
Re: [qemu-s390x] [PATCH 1/3] exec: fix memory leak in find_max_supported_pagesize() |
Date: |
Thu, 29 Mar 2018 13:47:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 29.03.2018 11:09, Greg Kurz wrote:
> The string returned by object_property_get_str() is dynamically allocated.
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> exec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/exec.c b/exec.c
> index c09bd93df31e..02b1efebb7c3 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1495,6 +1495,7 @@ static int find_max_supported_pagesize(Object *obj,
> void *opaque)
> mem_path = object_property_get_str(obj, "mem-path", NULL);
> if (mem_path) {
> long hpsize = qemu_mempath_getpagesize(mem_path);
> + g_free(mem_path);
> if (hpsize < *hpsize_min) {
> *hpsize_min = hpsize;
> }
>
>
Reviewed-by: Thomas Huth <address@hidden>
[qemu-s390x] [PATCH 3/3] sev/i386: fix memory leak in sev_guest_init(), Greg Kurz, 2018/03/29