Re: [qemu-s390x] [Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

[Tony Krowiak]

On 03/16/2018 06:38 AM, Pierre Morel wrote:
> On 16/03/2018 00:24, Tony Krowiak wrote:
> > This patch introduces the base object for an AP device.
> >
> > Signed-off-by: Tony Krowiak <address@hidden>
> > ---
> >   hw/s390x/Makefile.objs       |    1 +
> >   hw/s390x/ap-device.c         |   38 
> > ++++++++++++++++++++++++++++++++++++++
> >   include/hw/s390x/ap-device.h |   38 
> > ++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 77 insertions(+), 0 deletions(-)
> >   create mode 100644 hw/s390x/ap-device.c
> >   create mode 100644 include/hw/s390x/ap-device.h
> >
> > diff --git a/hw/s390x/Makefile.objs b/hw/s390x/Makefile.objs
> > index dc704b5..3247a07 100644
> > --- a/hw/s390x/Makefile.objs
> > +++ b/hw/s390x/Makefile.objs
> > @@ -17,3 +17,4 @@ obj-y += s390-stattrib.o
> >   obj-$(CONFIG_KVM) += s390-skeys-kvm.o
> >   obj-$(CONFIG_KVM) += s390-stattrib-kvm.o
> >   obj-y += s390-ccw.o
> > +obj-y += ap-device.o
> > diff --git a/hw/s390x/ap-device.c b/hw/s390x/ap-device.c
> > new file mode 100644
> > index 0000000..448f6db
> > --- /dev/null
> > +++ b/hw/s390x/ap-device.c
> > @@ -0,0 +1,38 @@
> > +/*
> > + * Adjunct Processor (AP) matrix device
> > + *
> > + * Copyright 2018 IBM Corp.
> > + * Author(s): Tony Krowiak <address@hidden>
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 
> > or (at
> > + * your option) any later version. See the COPYING file in the 
> > top-level
> > + * directory.
> > + */
> > +#include "qemu/osdep.h"
> > +#include "qemu/module.h"
> > +#include "qapi/error.h"
> > +#include "hw/qdev.h"
> > +#include "hw/s390x/ap-device.h"
> > +
> > +static void ap_class_init(ObjectClass *klass, void *data)
> > +{
> > +    DeviceClass *dc = DEVICE_CLASS(klass);
> > +
> > +    dc->desc = "AP device class";
>
> Shouldn't we make the AP devices unpluggable ?
Will do.
> > +}
> > +
> > +static const TypeInfo ap_device_info = {
> > +    .name = AP_DEVICE_TYPE,
> > +    .parent = TYPE_DEVICE,
> > +    .instance_size = sizeof(APDevice),
> > +    .class_size = sizeof(APDeviceClass),
> > +    .class_init = ap_class_init,
> > +    .abstract = true,
> > +};
> > +
> > +static void ap_device_register(void)
> > +{
> > +    type_register_static(&ap_device_info);
> > +}
> > +
> > +type_init(ap_device_register)
> > diff --git a/include/hw/s390x/ap-device.h b/include/hw/s390x/ap-device.h
> > new file mode 100644
> > index 0000000..693df90
> > --- /dev/null
> > +++ b/include/hw/s390x/ap-device.h
> > @@ -0,0 +1,38 @@
> > +/*
> > + * Adjunct Processor (AP) matrix device interfaces
> > + *
> > + * Copyright 2018 IBM Corp.
> > + * Author(s): Tony Krowiak <address@hidden>
> > + *
> > + * This work is licensed under the terms of the GNU GPL, version 2 
> > or (at
> > + * your option) any later version. See the COPYING file in the 
> > top-level
> > + * directory.
> > + */
> > +#ifndef HW_S390X_AP_DEVICE_H
> > +#define HW_S390X_AP_DEVICE_H
> > +
> > +#define AP_DEVICE_TYPE       "ap-device"
> > +
> > +typedef struct APDevice {
> > +    DeviceState parent_obj;
> > +} APDevice;
> > +
> > +typedef struct APDeviceClass {
> > +    DeviceClass parent_class;
> > +} APDeviceClass;
> > +
> > +static inline APDevice *to_ap_dev(DeviceState *dev)
> > +{
> > +    return container_of(dev, APDevice, parent_obj);
> > +}
> > +
> > +#define AP_DEVICE(obj) \
> > +    OBJECT_CHECK(APDevice, (obj), AP_DEVICE_TYPE)
> > +
> > +#define AP_DEVICE_GET_CLASS(obj) \
> > +    OBJECT_GET_CLASS(APDeviceClass, (obj), AP_DEVICE_TYPE)
> > +
> > +#define AP_DEVICE_CLASS(klass) \
> > +    OBJECT_CLASS_CHECK(APDeviceClass, (klass), AP_DEVICE_TYPE)
> > +
> > +#endif /* HW_S390X_AP_DEVICE_H */