Re: [qemu-s390x] [PATCH v2] pc-bios/s390-ccw: Move string arrays from bootmap header to .c file

[Cornelia Huck]

On Tue,  6 Mar 2018 07:18:01 +0100
Thomas Huth <address@hidden> wrote:

> bootmap.h can currently only be included once - otherwise the linker
> complains about multiple definitions of the "magic" strings. It's a
> bad style to define string arrays in header files, so let's better
> move these to the bootmap.c file instead where they are used.
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  v2:
>  - Removed duplicated vol_desc_magic (copy-n-paste error)
> 
>  pc-bios/s390-ccw/bootmap.c | 20 ++++++++++++++++++++
>  pc-bios/s390-ccw/bootmap.h | 19 -------------------
>  2 files changed, 20 insertions(+), 19 deletions(-)

Thanks, applied (without rebuild as this is no functional change).