Re: [qemu-s390x] [PATCH v2] s390x/sclpconsole: Remove dead code - delete error handlers

[Cornelia Huck]

On Tue, 6 Mar 2018 09:13:33 +0100
Christian Borntraeger <address@hidden> wrote:

> On 03/05/2018 06:49 PM, Nia Alarie wrote:
> > The other event handlers (quiesce and cpu) do not define these
> > handlers, and this one does nothing, so it can be removed.
> > 
> > virtio_ccw_exit always returns 0, so change its return type to
> > void.
> > 
> > Signed-off-by: Nia Alarie <address@hidden>  
> 
> 
> I would like to have 2 patches to make the subject non-misleading.
> 
> patch1: sclp/event
> patch2: virtio-ccw

Yes, please. sclp/event and virtio-ccw are two different code paths.

Also, looking at the virtio-ccw part: Rather than modifying exit
handlers, the code should be converted to unrealize instead.

> 
> With that
> Reviewed-by: Christian Borntraeger <address@hidden>
> 
> > ---
> >  hw/char/sclpconsole-lm.c          |  6 ------
> >  hw/char/sclpconsole.c             |  6 ------
> >  hw/s390x/event-facility.c         | 14 --------------
> >  hw/s390x/virtio-ccw.c             |  6 +++---
> >  hw/s390x/virtio-ccw.h             |  2 +-
> >  include/hw/s390x/event-facility.h |  1 -
> >  6 files changed, 4 insertions(+), 31 deletions(-)

I'd be happy to merge the sclp part for 2.12 if I get the patch
Thursday morning CET latest.

I'd be happy to merge an unrealize conversion for virtio-ccw as well,
but I'm not sure how much work that is (although it looks manageable).