[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] target/s390x: Remove leading underscores from #
|
From: |
Cornelia Huck |
|
Subject: |
Re: [qemu-s390x] [PATCH] target/s390x: Remove leading underscores from #defines |
|
Date: |
Mon, 5 Mar 2018 12:11:45 +0100 |
On Mon, 5 Mar 2018 06:16:58 +0100
Thomas Huth <address@hidden> wrote:
> We should not use leading underscores followed by a capital letter
> in #defines since such identifiers are reserved by the C standard.
>
> For ASCE_ORIGIN, REGION_ENTRY_ORIGIN and SEGMENT_ENTRY_ORIGIN I also
> added parentheses around the value to silence an error message from
> checkpatch.pl.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> target/s390x/cpu.h | 66
> +++++++++++++++++++++++------------------------
> target/s390x/mem_helper.c | 20 +++++++-------
> target/s390x/mmu_helper.c | 54 +++++++++++++++++++-------------------
> 3 files changed, 70 insertions(+), 70 deletions(-)
Thanks, applied.