Re: [qemu-s390x] [PATCHv5 2/5] qmp: add query-cpus-fast

[Cornelia Huck]

On Fri, 16 Feb 2018 17:08:38 +0100
Viktor Mihajlovski <address@hidden> wrote:

> From: Luiz Capitulino <address@hidden>
> 
> The query-cpus command has an extremely serious side effect:
> it always interrupts all running vCPUs so that they can run
> ioctl calls. This can cause a huge performance degradation for
> some workloads. And most of the information retrieved by the
> ioctl calls are not even used by query-cpus.
> 
> This commit introduces a replacement for query-cpus called
> query-cpus-fast, which has the following features:
> 
>  o Never interrupt vCPUs threads. query-cpus-fast only returns
>    vCPU information maintained by QEMU itself, which should be
>    sufficient for most management software needs
> 
>  o Drop "halted" field as it can not be retrieved in a fast
>    way on most architectures
> 
>  o Drop irrelevant fields such as "current", "pc" and "arch"
> 
>  o Rename some fields for better clarification & proper naming
>    standard
> 
> Signed-off-by: Luiz Capitulino <address@hidden>
> Signed-off-by: Viktor Mihajlovski <address@hidden>
> ---
>  cpus.c           | 38 ++++++++++++++++++++++++++++++
>  qapi-schema.json | 70 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 108 insertions(+)

Reviewed-by: Cornelia Huck <address@hidden>