Re: [qemu-s390x] [PATCHv3 4/4] qemu-doc: deprecate query-cpus and info cpus

[Eric Blake]

On 02/15/2018 04:20 AM, Viktor Mihajlovski wrote:
> Start the deprecation period for QAPI query-cpus (replaced by
> query-cpus-fast) and HMP 'info cpus' (replaced by 'info cpus_fast')
> beginning with 2.12.0.

See my comments on 2/4 - if we want, we could just make HMP 'info cpus' 
be the fast version, with no slow version counterpart, right away 
without a deprecation period.  If we do that, then...

> Signed-off-by: Viktor Mihajlovski <address@hidden>
> ---
>   hmp-commands-info.hx |  4 ++--
>   qapi-schema.json     |  4 ++++
>   qemu-doc.texi        | 10 ++++++++++
>   3 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index 16ac602..2ccb9c7 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -149,14 +149,14 @@ ETEXI
>           .name       = "cpus",
>           .args_type  = "",
>           .params     = "",
> -        .help       = "show infos for each CPU",
> +        .help       = "show infos for each CPU (deprecated, use info cpus_fast 
> instead)",

changes to this file no longer need to happen in this patch, and


> +++ b/qemu-doc.texi
> @@ -2757,6 +2757,12 @@ used and it will be removed with no replacement.
>   The ``convert -s snapshot_id_or_name'' argument is obsoleted
>   by the ``convert -l snapshot_param'' argument instead.
>   
> address@hidden System emulator monitor commands
> +
> address@hidden query-cpus (since 2.12.0)
> +
> +The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command.
> +
>   @section System emulator human monitor commands
>   
>   @subsection host_net_add (since 2.10.0)
> @@ -2767,6 +2773,10 @@ The ``host_net_add'' command is replaced by the 
> ``netdev_add'' command.
>   
>   The ``host_net_remove'' command is replaced by the ``netdev_del'' command.
>   
> address@hidden info cpus (since 2.12.0)
> +
> +The ``info cpus'' command is replaced by the ``info cpus_fast'' command.
> +

this hunk could be dropped.

But if we really want a deprecation period on the HMP side as well, then 
this patch is fine.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org