[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v2] s390x/tcg: add various alignment check
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH v2] s390x/tcg: add various alignment check |
Date: |
Thu, 15 Feb 2018 11:10:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 15.02.2018 10:49, Cornelia Huck wrote:
> On Thu, 15 Feb 2018 10:47:45 +0100
> David Hildenbrand <address@hidden> wrote:
>
>> On 14.02.2018 20:04, Richard Henderson wrote:
>>> On 02/14/2018 09:31 AM, David Hildenbrand wrote:
>>>> Let's add proper alignment checks for a handful of instructions that
>>>> require a SPECIFICATION exception in case alignment is violated.
>>>>
>>>> Introduce new wout/in functions. Declare them as "static inline" to avoid
>>>> warnings about not being used for CONFIG_USER_ONLY (as we are right
>>>> now only using them for privileged instructions).
>>>
>>> Annoyingly, clang will still warn for this.
>>>
>>
>> Hm, so the only solution is to add nasty idfefs then :(
>
> Yup, very annoying indeed, but probably the only way to shut clang up...
>
Will resend soon!
--
Thanks,
David / dhildenb