[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH 11/30] hw/s390x: use the BYTE-based definitions
|
From: |
Thomas Huth |
|
Subject: |
Re: [qemu-s390x] [PATCH 11/30] hw/s390x: use the BYTE-based definitions |
|
Date: |
Thu, 15 Feb 2018 08:05:39 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 15.02.2018 05:28, Philippe Mathieu-Daudé wrote:
> It ease code review, unit is explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/s390x/sclp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> index 276972b59f..8537aa2688 100644
> --- a/hw/s390x/sclp.c
> +++ b/hw/s390x/sclp.c
> @@ -526,8 +526,8 @@ static void sclp_realize(DeviceState *dev, Error **errp)
>
> ret = s390_set_memory_limit(machine->maxram_size, &hw_limit);
> if (ret == -E2BIG) {
> - error_setg(&err, "host supports a maximum of %" PRIu64 " GB",
> - hw_limit >> 30);
> + error_setg(&err, "host supports a maximum of %llu GB",
> + hw_limit / G_BYTE);
> } else if (ret) {
> error_setg(&err, "setting the guest size failed");
> }
Reviewed-by: Thomas Huth <address@hidden>