[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1] s390x/tcg: add various alignment check
|
From: |
David Hildenbrand |
|
Subject: |
Re: [qemu-s390x] [PATCH v1] s390x/tcg: add various alignment check |
|
Date: |
Wed, 14 Feb 2018 17:26:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 14.02.2018 17:05, Richard Henderson wrote:
> On 02/14/2018 07:25 AM, David Hildenbrand wrote:
>> /* SET CLOCK COMPARATOR */
>> - C(0xb206, SCKC, S, Z, 0, m2_64, 0, 0, sckc, 0)
>> + C(0xb206, SCKC, S, Z, 0, a2, 0, 0, sckc, 0)
>
> Rather than move the memory load into the op_ functions, better to add an
> m2_64a (etc) functions that apply the alignment.
Jup, also had that in mind, moves the magic to a different place. Will
play with it.
>
>
> r~
>
--
Thanks,
David / dhildenb