Re: [qemu-s390x] [PATCH v6] s390x/cpu: expose the guest crash information

[Eric Blake]

On 02/07/2018 12:44 PM, Christian Borntraeger wrote:

> > +        } else if (info->type == GUEST_PANIC_INFORMATION_TYPE_S390) {
> > +            qemu_log_mask(LOG_GUEST_ERROR, " on cpu %d: %s\n"
> > +                          "PSW: 0x%016" PRIx64 " 0x%016" PRIx64"\n",
> > +                          info->u.s390.core,
> > +                          qapi_enum_lookup(&S390CrashReason_lookup,
> > +                                           info->u.s390.reason),
>
> Question for the qapi people. Would you prefer S390CrashReason_str instead?

Yes, S390CrashReason_str(info->u.s390.reason) is a more legible way to 
spell this same lookup, and leaves the door open if we later change how 
the internal &S390CrashReason_lookup[] behaves.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org