[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v3 01/18] s390x/tcg: deliver multiple interrupts in
From: |
David Hildenbrand |
Subject: |
[qemu-s390x] [PATCH v3 01/18] s390x/tcg: deliver multiple interrupts in a row |
Date: |
Mon, 29 Jan 2018 13:56:06 +0100 |
We have to consider all deliverable interrupts.
We now have to take care of the special scenario, where we first
inject an interrupt with a WAIT PSW, followed by a !WAIT PSW. (very
unlikely but possible)
Signed-off-by: David Hildenbrand <address@hidden>
---
target/s390x/excp_helper.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c
index e8f7a40c2b..97caa7f418 100644
--- a/target/s390x/excp_helper.c
+++ b/target/s390x/excp_helper.c
@@ -433,10 +433,12 @@ void s390_cpu_do_interrupt(CPUState *cs)
{
S390CPU *cpu = S390_CPU(cs);
CPUS390XState *env = &cpu->env;
+ bool stopped = false;
qemu_log_mask(CPU_LOG_INT, "%s: %d at pc=%" PRIx64 "\n",
__func__, cs->exception_index, env->psw.addr);
+try_deliver:
/* handle machine checks */
if (cs->exception_index == -1 && s390_cpu_has_mcck_int(cpu)) {
cs->exception_index = EXCP_MCHK;
@@ -479,13 +481,14 @@ void s390_cpu_do_interrupt(CPUState *cs)
break;
case EXCP_STOP:
do_stop_interrupt(env);
+ stopped = true;
break;
}
- /* WAIT PSW during interrupt injection or STOP interrupt */
- if (cs->exception_index == EXCP_HLT) {
- /* don't trigger a cpu_loop_exit(), use an interrupt instead */
- cpu_interrupt(CPU(cpu), CPU_INTERRUPT_HALT);
+ if (cs->exception_index != -1 && !stopped) {
+ /* check if there are more pending interrupts to deliver */
+ cs->exception_index = -1;
+ goto try_deliver;
}
cs->exception_index = -1;
@@ -493,6 +496,15 @@ void s390_cpu_do_interrupt(CPUState *cs)
if (!env->pending_int) {
cs->interrupt_request &= ~CPU_INTERRUPT_HARD;
}
+
+ /* WAIT PSW during interrupt injection or STOP interrupt */
+ if ((env->psw.mask & PSW_MASK_WAIT) || stopped) {
+ /* don't trigger a cpu_loop_exit(), use an interrupt instead */
+ cpu_interrupt(CPU(cpu), CPU_INTERRUPT_HALT);
+ } else if (cs->halted) {
+ /* unhalt if we had a WAIT PSW somehwere in our injection chain */
+ s390_cpu_unhalt(cpu);
+ }
}
bool s390_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
--
2.14.3
- [qemu-s390x] [PATCH v3 00/18] s390x: flic rework, tcg flic support and STSI, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 01/18] s390x/tcg: deliver multiple interrupts in a row,
David Hildenbrand <=
- [qemu-s390x] [PATCH v3 02/18] s390x/flic: simplify flic initialization, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 04/18] s390x/tcg: simplify machine check handling, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 03/18] s390x/tcg: simplify lookup of flic, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 05/18] s390x/flic: factor out injection of floating interrupts, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 06/18] s390x/flic: no need to call s390_io_interrupt() from flic, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 07/18] s390x/tcg: tolerate wrong wakeups due to floating interrupts, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 08/18] s390x/flic: make floating interrupts on TCG actually floating, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 09/18] s390x/tcg: implement TEST PENDING INTERRUPTION, David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 10/18] s390x/flic: implement qemu_s390_clear_io_flic(), David Hildenbrand, 2018/01/29
- [qemu-s390x] [PATCH v3 11/18] s390x/flic: optimize CPU wakeup for TCG, David Hildenbrand, 2018/01/29