Re: [qemu-s390x] [PATCH v4 03/10] s390-ccw: refactor IPL structs

[Collin L. Walling]

On 01/25/2018 06:39 AM, Thomas Huth wrote:
> On 23.01.2018 19:26, Collin L. Walling wrote:
> > ECKD DASDs have different IPL structures for CDL and LDL
> > formats. The current Ipl1 and Ipl2 structs follow the CDL
> > format, so we prepend "EckdCdl" to them. Boot info for LDL
> > has been moved to a new struct: EckdLdlIpl1.
> >
> > Also introduce structs for IPL stages 1 and 1b.
> I'd maybe move the 1b stuff into a later patch, when you really need it.

Makes sense to me.

> By the way, is there a public spec available somewhere for these ECKD
> boot structures?

The zipl source code should be available if you have the time and
want to understand the nitty-gritty of how all the data gets written.

https://github.com/ibm-s390-tools/s390-tools/tree/master/zipl

I'm also fairly confident we have a document available /somewhere/...
I'll ask around and provide something for you ASAP.

> Anyway, patch looks fine to me, so:
>
> Reviewed-by: Thomas Huth <address@hidden>

Thanks for the review!

--
- Collin L Walling