Re: [qemu-s390x] [PATCH v2 00/18] s390x: flic rework, tcg flic support and STSI

[David Hildenbrand]

On 25.01.2018 13:47, Cornelia Huck wrote:
> On Thu, 25 Jan 2018 13:42:41 +0100
> Cornelia Huck <address@hidden> wrote:
> 
>> On Wed, 17 Jan 2018 18:40:29 +0100
>> David Hildenbrand <address@hidden> wrote:
>>
>>> This patch series implements floating interrupt support for TCG and fixes
>>> STSI so we can remove warnings related to s390x SMP and MTTCG.
>>>
>>> KVM code has to be touched in order to factor out the injection routines
>>> into the flic ("s390x/flic: factor out injection of floating interrupts").
>>> Basic testing didn't reveal any problems so far.
>>>
>>> With this series I am now able to run fedora 26/27 and Ubuntu 17.10+ with
>>> 16 VCPUs (MTTCG) on a 8CPU host, doing a make -j16 in the guest. I got
>>> nasty stalls in the guest beforehand.
>>>
>>> Now also included: More flic related caching to avoid recurring
>>> conversions.  
>>
>> Hm...
>>
>> (qemu) device_add virtio-net-ccw,id=xxx
>> (qemu) **
>> ERROR:/home/cohuck/git/qemu/target/s390x/excp_helper.c:342:do_mchk_interrupt:
>>  assertion failed: (env->cregs[14] & CR0_SERVICE_SC)
>> Aborted (core dumped)
> 
> Works much better if you check for CR14_CHANNEL_REPORT_SC instead :)
> 

Thanks for testing and spotting the wrong assert!

-- 

Thanks,

David / dhildenb