[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v4 1/7] accel/tcg: add size paremeter in tlb_fil
From: |
Laurent Vivier |
Subject: |
Re: [qemu-s390x] [PATCH v4 1/7] accel/tcg: add size paremeter in tlb_fill() |
Date: |
Tue, 23 Jan 2018 23:11:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
Le 18/01/2018 à 20:38, Laurent Vivier a écrit :
> The MC68040 MMU provides the size of the access that
> triggers the page fault.
>
> This size is set in the Special Status Word which
> is written in the stack frame of the access fault
> exception.
>
> So we need the size in m68k_cpu_unassigned_access() and
> m68k_cpu_handle_mmu_fault().
>
> To be able to do that, this patch modifies the prototype of
> handle_mmu_fault handler, tlb_fill() and probe_write().
> do_unassigned_access() already includes a size parameter.
I'd like to send a pull request for m68k MMU series, and 68040 MMU
relies on this patch.
If someone disagrees with this change, it's time to say it!
Thanks,
Laurent