[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] s390x/tcg: fixup TEST PROTECTION
From: |
Cornelia Huck |
Subject: |
Re: [qemu-s390x] [PATCH] s390x/tcg: fixup TEST PROTECTION |
Date: |
Fri, 19 Jan 2018 12:56:00 +0100 |
On Fri, 12 Jan 2018 13:54:52 +0100
David Hildenbrand <address@hidden> wrote:
> CC == 2 can only happen due to a protection exception, not if memory is
> not available (PGM_ADDRESSING). So all PGM_ADDRESSING exceptions have to
> be forwarded to the guest.
>
> Since the initial definition of TEST PROTECTION, we now read globals
> (e.g. PSW mask), so we have to correctly mark the instruction
> (otherwise, e.g. booting fedora 27 fails).
>
> Also, the architecture explicitly specifies which exceptions are
> forwarded to the guest, this makes the code a little nicer.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/cpu.h | 2 ++
> target/s390x/helper.h | 2 +-
> target/s390x/EM_helper.c | 41 +++++++++++++++++++----------------------
> 3 files changed, 22 insertions(+), 23 deletions(-)
Thanks, applied.