Re: [qemu-s390x] [Qemu-devel] [PATCH v3 1/8] s390-ccw: update libc

[Collin L. Walling]

On 01/16/2018 06:07 AM, Christian Borntraeger wrote:
> On 01/15/2018 06:23 PM, Collin L. Walling wrote:
> > On 01/15/2018 12:05 PM, Eric Blake wrote:
> > > On 01/15/2018 10:44 AM, Collin L. Walling wrote:
> > > > Moved:
> > > >     memcmp from bootmap.h to libc.h (renamed from _memcmp)
> > > >     strlen from sclp.c to libc.h (renamed from _strlen)
> > > >
> > > > Added C standard functions:
> > > >     isdigit
> > > >     atoi
> > > >
> > > > Added non-C standard function:
> > > >     itostr
> > > >
> > > > Signed-off-by: Collin L. Walling <address@hidden>
> > > > Acked-by: Christian Borntraeger <address@hidden>
> > > > Reviewed-by: Janosch Frank <address@hidden>
> > > > ---
> > > > +++ b/pc-bios/s390-ccw/libc.c
> > > > @@ -0,0 +1,83 @@
> > > > +/*
> > > > + * libc-style definitions and functions
> > > > + *
> > > > + * This code is free software; you can redistribute it and/or modify it
> > > > + * under the terms of the GNU General Public License as published by the
> > > > + * Free Software Foundation; either version 2 of the License, or (at your
> > > > + * option) any later version.
> > > I'm not a lawyer, but generically, the GPL and its variants depend on a
> > > copyright owner to actually work.  You may want to add a copyright line.
> >
> > I'll have to check on that.  I was not the original author of the libc.h file.
> I think you can add the normal IBM Copyright statement. (I think all authors 
> could add theirs as well)

"Copyright 2018 IBM Corp."

@Thomas, git shows you as the initial creator of libc.h.  Shall I add
"Copyright 2018 Thomas Huth, Red Hat Inc." in there as well?

--
- Collin L Walling