[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [Qemu-devel] [PATCH v3 0/7] improve error handling for
From: |
Dong Jia Shi |
Subject: |
Re: [qemu-s390x] [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr |
Date: |
Thu, 19 Oct 2017 14:01:13 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Cornelia Huck <address@hidden> [2017-10-18 11:53:10 +0200]:
> On Wed, 18 Oct 2017 16:23:47 +0800
> Dong Jia Shi <address@hidden> wrote:
>
> > * Halil Pasic <address@hidden> [2017-10-17 18:19:20 +0200]:
> >
> > [...]
> >
> > > >> Testing
> > > >> =======
> > > >>
> > > >> Nothing happened since v2 except for a quick smoke test. Dong Jia gave
> > > >> v2
> > > >> a spin with a focus on vfio-ccw. @Dong Jia I would appreciate some
> > > >> proper
> > > >> testing, especially regarding the changes in vfio-ccw (patch #3).
> > > >
> > > > Looks sane to me (if needed, I can fix up the minor things I found).
> > > >
> > > > In addition to some testing, I'd appreciate some review from others as
> > > > well.
> > > >
> > >
> > > Of course, I'm fine with the fixes (won't answer individually). I think
> > > both Dong Jia and Pierre have already put enough work in this to be
> > > credited
> > > with a tag, so I really hope they will get around to review this. I would
> > > be especially happy with an Tested-by: Dong Jia since this series is quite
> > > under-tested, and the changes in vfio-ccw aren't just minor.
> > >
> > > Of course I could come up with a test setup myself, but I hope Dong Jia
> > > already has one, and he is certainly more involved with vfio-ccw.
> > >
> > Using Conny's s390-next branch + this series (#2-#7), I didn't notice
> > any obvious problem during my fio test. So for the vfio-ccw related
> > part:
> > Tested-by: Dong Jia Shi <address@hidden>
>
> Thanks!
>
> To which patches may I add the tag? :)
>
The test should cover the vfio-ccw related part in patch #3, I assume.
So add it there?
--
Dong Jia Shi