[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] rust: enable clippy::ptr_cast_constness
|
From: |
Stefan Zabka |
|
Subject: |
Re: [PATCH 8/9] rust: enable clippy::ptr_cast_constness |
|
Date: |
Fri, 2 May 2025 20:57:33 +0200 |
Unrelated to the actual change, but a drive-by observation:
If you want to keep the MSRV in sync across all workspace members, you
could use workspace.package.rust-version to define it once and inherit
it everywhere. (Same goes for edition, license, and resolver.)
https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table
I'd like to provide a patch instead of just heckling, but I have a
couple of questions:
1. Is this actually desired behaviour, or might you want different
values for these fields?
2. Should I implement this against qemu-project/qemu master branch or is
there a dedicated Rust tree?
3. Should I wait with that until your change is landed so we don't conflict?
Best
Stefan
- [PATCH 4/9] rust: qemu_api_macros: use "let ... else", (continued)
- [PATCH 6/9] rust: remove offset_of replacement, Paolo Bonzini, 2025/05/02
- [PATCH 8/9] rust: enable clippy::ptr_cast_constness, Paolo Bonzini, 2025/05/02
- [PATCH 7/9] rust: replace c_str! with c"" literals, Paolo Bonzini, 2025/05/02
- [PATCH 9/9] docs: rust: update for newer minimum supported version, Paolo Bonzini, 2025/05/02
- Re: [PATCH 0/9] rust: allow minimum version of 1.77, Manos Pitsidianakis, 2025/05/02