[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/9] hw/intc: sifive_plic: Cleanup remaining functions
|
From: |
Bin Meng |
|
Subject: |
Re: [PATCH v2 4/9] hw/intc: sifive_plic: Cleanup remaining functions |
|
Date: |
Tue, 21 Dec 2021 16:22:33 +0800 |
On Thu, Dec 16, 2021 at 12:55 PM Alistair Francis
<alistair.francis@opensource.wdc.com> wrote:
>
> From: Alistair Francis <alistair.francis@wdc.com>
>
> We can remove the original sifive_plic_irqs_pending() function and
> instead just use the sifive_plic_claim() function (renamed to
> sifive_plic_claimed()) to determine if any interrupts are pending.
>
> This requires move the side effects outside of sifive_plic_claimed(),
> but as they are only invoked once that isn't a problem.
>
> We have also removed all of the old #ifdef debugging logs, so let's
> cleanup the last remaining debug function while we are here.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> hw/intc/sifive_plic.c | 109 +++++++++---------------------------------
> 1 file changed, 22 insertions(+), 87 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
- [PATCH v2 0/9] A collection of RISC-V cleanups and improvements, Alistair Francis, 2021/12/15
- [PATCH v2 1/9] hw/intc: sifive_plic: Add a reset function, Alistair Francis, 2021/12/15
- [PATCH v2 2/9] hw/intc: sifive_plic: Cleanup the write function, Alistair Francis, 2021/12/15
- [PATCH v2 3/9] hw/intc: sifive_plic: Cleanup the read function, Alistair Francis, 2021/12/15
- [PATCH v2 4/9] hw/intc: sifive_plic: Cleanup remaining functions, Alistair Francis, 2021/12/15
- Re: [PATCH v2 4/9] hw/intc: sifive_plic: Cleanup remaining functions,
Bin Meng <=
- [PATCH v2 5/9] target/riscv: Mark the Hypervisor extension as non experimental, Alistair Francis, 2021/12/15
- [PATCH v2 6/9] target/riscv: Enable the Hypervisor extension by default, Alistair Francis, 2021/12/15
- [PATCH v2 7/9] hw/riscv: Use error_fatal for SoC realisation, Alistair Francis, 2021/12/15
- [PATCH v2 8/9] hw/riscv: virt: Allow support for 32 cores, Alistair Francis, 2021/12/15