Re: [PATCH v1 1/2] target/riscv: Remove some unused macros

[Bin Meng]

On Mon, Oct 18, 2021 at 5:30 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 10/18/21 06:32, Alistair Francis wrote:
> > From: Alistair Francis <alistair.francis@wdc.com>
>
> Possible commit description:
>
>  Since commit 1a9540d1f1a ("target/riscv: Drop support for ISA
>  spec version 1.09.1") these definitions are unused, remove them.

I believe the commit tag should come in the same line otherwise it may
break any script that extracts such from the commit message.

>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

>
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> >  target/riscv/cpu_bits.h | 8 --------
> >  1 file changed, 8 deletions(-)
>
> BTW I strongly suggest you to use git-publish for your
> series / pull requests:
>
>   https://github.com/stefanha/git-publish
>

Regards,
Bin