[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] numa: Require distance map when empty node exists
From: |
Andrew Jones |
Subject: |
Re: [PATCH v3 1/2] numa: Require distance map when empty node exists |
Date: |
Fri, 15 Oct 2021 10:33:59 +0200 |
On Fri, Oct 15, 2021 at 07:22:05PM +1100, Gavin Shan wrote:
> It's possible that the empty NUMA nodes aren't referred by any CPUs,
> as the following command line indicate. In this case, the empty NUMA
> node IDs aren't existing in device-tree CPU nodes. So we still need
> the distance-map.
Ah, indeed.
>
> However, I would like to drop this (PATCH[01/02]) in v4. The memory
> hotplug through device-tree on ARM64 isn't existing. We might have
> alternative ways to present the empty NUMA nodes when it's supported,
> or we needn't it for ever because ACPI is enough to support the
> memory hotplug.
Agreed. Please update the commit message of 2/2 for v4 and also add
a comment above the new code with the rationale for dropping those
memory nodes.
Thanks,
drew