[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 5/5] [RISCV_PM] Support pointer masking for RISC-V for i/c/f/d/a types of instructions |
|
Date: |
Wed, 14 Oct 2020 12:24:49 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 10/14/20 10:01 AM, Alexey Baturo wrote:
> + if (has_ext(ctx, RVJ)) {
> + src1 = apply_pointer_masking(ctx, src1);
> + }
The if is redundant, since that will have been done in cpu_get_tb_cpu_state
while assigning pm_enabled.
The test for pm_enabled is in gen_pm_adjust_address.
The final thing is that the API for apply_pointer_masking is misleading. Here,
it appears as if you are allocating a new temporary and assigning it to src1.
Which is not the case.
I suggest you drop apply_pointer_masking and just use gen_pm_adjust_address.
r~