Re: [RFC v4 42/70] target/riscv: rvv-1.0: integer add-with-carry/subtract-with-borrow

[Richard Henderson]

On 8/17/20 1:49 AM, frank.chang@sifive.com wrote:
> From: Frank Chang <frank.chang@sifive.com>
> 
> Clear tail elements only if VTA is agnostic.
> 
> Signed-off-by: Frank Chang <frank.chang@sifive.com>
> ---
>  target/riscv/insn32.decode              | 20 ++++++++++----------
>  target/riscv/insn_trans/trans_rvv.inc.c |  2 +-
>  target/riscv/vector_helper.c            | 14 ++++----------
>  3 files changed, 15 insertions(+), 21 deletions(-)

The patch description is wrong, but the code is correct.

One nit:

> -        uint8_t carry = vext_elem_mask(v0, i);                \
> +        uint8_t carry = !vm ? vext_elem_mask(v0, i) : 0;      \

    ETYPE carry = !vm && vext_elem_mask(v0, i);


r~