[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 12/65] target/riscv: rvv-0.9: update check functions
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC 12/65] target/riscv: rvv-0.9: update check functions |
|
Date: |
Fri, 10 Jul 2020 10:51:06 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 7/10/20 3:48 AM, frank.chang@sifive.com wrote:
> +#define REQUIRE_RVV do { \
> + if (s->mstatus_vs == 0) \
> + return false; \
> +} while (0)
You've used this macro already back in patch 7. I guess it should not have
been there? Or this bit belongs there, one or the other.
I think this patch requires a description and justification. I have no idea
why you are replacing
> - return (vext_check_isa_ill(s) &&
> - vext_check_overlap_mask(s, a->rd, a->vm, false) &&
> - vext_check_reg(s, a->rd, false) &&
> - vext_check_reg(s, a->rs2, false) &&
> - vext_check_reg(s, a->rs1, false));
with invisible returns
> + REQUIRE_RVV;
> + VEXT_CHECK_ISA_ILL(s);
> + VEXT_CHECK_SSS(s, a->rd, a->rs1, a->rs2, a->vm, true);
> + return true;
r~
- Re: [RFC 60/65] softfloat: add fp16 and uint8/int8 interconvert functions, (continued)
[RFC 63/65] fpu: implement full set compare for fp16, frank . chang, 2020/07/10
[RFC 11/65] target/riscv: rvv-0.9: add fractional LMUL, VTA and VMA, frank . chang, 2020/07/10
[RFC 12/65] target/riscv: rvv-0.9: update check functions, frank . chang, 2020/07/10
- Re: [RFC 12/65] target/riscv: rvv-0.9: update check functions,
Richard Henderson <=
[RFC 17/65] target/riscv: rvv-0.9: fault-only-first unit stride load, frank . chang, 2020/07/10
[RFC 18/65] target/riscv: rvv-0.9: amo operations, frank . chang, 2020/07/10
[RFC 29/65] target/riscv: rvv-0.9: integer scalar move instructions, frank . chang, 2020/07/10
[RFC 36/65] target/riscv: rvv-0.9: widening integer multiply-add instructions, frank . chang, 2020/07/10
[RFC 41/65] target/riscv: rvv-0.9: floating-point compare instructions, frank . chang, 2020/07/10
[RFC 42/65] target/riscv: rvv-0.9: single-width integer reduction instructions, frank . chang, 2020/07/10
[RFC 46/65] target/riscv: rvv-0.9: slide instructions, frank . chang, 2020/07/10
[RFC 48/65] target/riscv: rvv-0.9: narrowing fixed-point clip instructions, frank . chang, 2020/07/10
[RFC 49/65] target/riscv: rvv-0.9: floating-point move instructions, frank . chang, 2020/07/10