Re: [PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty

From:	Richard Henderson
Subject:	Re: [PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty
Date:	Tue, 14 Jan 2020 05:47:03 -1000
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/14/20 12:14 AM, address@hidden wrote:
>      tcg_gen_ori_tl(tmp, tmp, MSTATUS_FS);
> +    tcg_gen_ori_tl(tmp, tmp, MSTATUS_SD);

Merge these:

  tcg_gen_ori_tl(tmp, tmp, MSTATUS_FS | MSTATUS_SD);

The TCG optimizer doesn't try to handle this sort of thing.

With that,
Reviewed-by: Richard Henderson <address@hidden>


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 1/3] target/riscv: Fix tb->flags FS status, shihpo . hung, 2020/01/14
- [PATCH v2 2/3] target/riscv: fsd/fsw doesn't dirty FP state, shihpo . hung, 2020/01/14
  - Re: [PATCH v2 2/3] target/riscv: fsd/fsw doesn't dirty FP state, Richard Henderson, 2020/01/14
- [PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty, shihpo . hung, 2020/01/14
  - Re: [PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty, Richard Henderson <=
- Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status, Richard Henderson, 2020/01/14
  - Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status, ShihPo Hung, 2020/01/15

Prev by Date: Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status
Next by Date: Re: [PATCH v2 2/3] target/riscv: fsd/fsw doesn't dirty FP state
Previous by thread: [PATCH v2 3/3] target/riscv: update mstatus.SD when FS is set dirty
Next by thread: Re: [PATCH v2 1/3] target/riscv: Fix tb->flags FS status
Index(es):
- Date
- Thread