|
From: | Richard Henderson |
Subject: | Re: [Qemu-riscv] [Qemu-devel] [PATCH] riscv: rv32: Root page table address can be larger than 32-bit |
Date: | Wed, 31 Jul 2019 10:35:49 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 7/31/19 5:45 AM, Bin Meng wrote: > - target_ulong base; > + hwaddr base; ... > - target_ulong pte_addr = base + idx * ptesize; > + hwaddr pte_addr = base + idx * ptesize; I believe that you either need base + (hwaddr)idx * ptesize or change the type of idx to hwaddr above. Otherwise the multiply overflows before it gets promoted with the add. r~
[Prev in Thread] | Current Thread | [Next in Thread] |