[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-riscv] [Qemu-devel] [PATCH for-4.1 1/8] target/riscv: Name the
|
From: |
Aleksandar Markovic |
|
Subject: |
Re: [Qemu-riscv] [Qemu-devel] [PATCH for-4.1 1/8] target/riscv: Name the argument sets for all of insn32 formats |
|
Date: |
Thu, 25 Apr 2019 07:31:49 +0200 |
On Apr 25, 2019 7:17 AM, "Richard Henderson" <address@hidden> wrote:
>
> On 4/24/19 8:31 PM, Palmer Dabbelt wrote:
> >> # Argument sets:
> >> +&empty
> >
> > If I understand decodetree correctly, this isn't used until patch 5.
> > Otherwise,
> >
>
> I think it's used as early as patch 3, but I haven't looked in detail to be sure.
>
>
> r~
>
I think it is a very bad practice to leave the commit message empty, and, in my view, the long-time contributor, like you, Richard, have the obligation to always give examples of commit messages of good quality. Leaving empty commit messages should not be a ”privelage” that comes with seniority, IMHO. On the contrary.
Sincerely,
Aleksandar