Re: [PATCH v5 1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h

[CALEB SCHLOSSIN]

On 6/26/24 11:05 AM, Chalapathi V wrote:
> In this commit target specific dependency from include/hw/ppc/pnv_xscom.h
> has been removed so that pnv_xscom.h can be included outside hw/ppc.
>
> Signed-off-by: Chalapathi V <chalapathi.v@linux.ibm.com>


Reviewed-by: Caleb Schlossin <calebs@linux.vnet.ibm.com>

Thanks,

Caleb Schlossin

---

From: Chalapathi V <chalapathi.v@linux.ibm.com>
Sent: Wednesday, June 26, 2024 4:05 AM
To: qemu-devel@nongnu.org <qemu-devel@nongnu.org>
Cc: qemu-ppc@nongnu.org <qemu-ppc@nongnu.org>; fbarrat@linux.ibm.com <fbarrat@linux.ibm.com>; npiggin@gmail.com <npiggin@gmail.com>; clg@kaod.org <clg@kaod.org>; CALEB SCHLOSSIN <calebs@us.ibm.com>; Chalapathi V <Chalapathi.V@ibm.com>; chalapathi.v@linux.ibm.com <chalapathi.v@linux.ibm.com>; saif.abrar@linux.ibm.com <saif.abrar@linux.ibm.com>; Dan Tan <dantan@us.ibm.com>; milesg@linux.ibm.com <milesg@linux.ibm.com>
Subject: [PATCH v5 1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h

 

In this commit target specific dependency from include/hw/ppc/pnv_xscom.h
has been removed so that pnv_xscom.h can be included outside hw/ppc.

Signed-off-by: Chalapathi V <chalapathi.v@linux.ibm.com>
---
 include/hw/ppc/pnv_xscom.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h
index 6209e18492..c8dd42bffd 100644
--- a/include/hw/ppc/pnv_xscom.h
+++ b/include/hw/ppc/pnv_xscom.h
@@ -21,9 +21,9 @@
 #define PPC_PNV_XSCOM_H
 
 #include "exec/memory.h"
-#include "hw/ppc/pnv.h"
 
 typedef struct PnvXScomInterface PnvXScomInterface;
+typedef struct PnvChip PnvChip;
 
 #define TYPE_PNV_XSCOM_INTERFACE "pnv-xscom-interface"
 #define PNV_XSCOM_INTERFACE(obj) \
--
2.39.3