Re: [PATCH 2/4] target/ppc: Move VSX vector with length storage access insns to decodetree.

[Richard Henderson]

On 6/9/24 11:11, Chinmay Rath wrote:
> The calculation of effective address in these instructions is slightly different than the 
> others,
> for which helper function exist :
>
> EA for these insns : EA ← (RA=0) ? 0 : GPR[RA]
> EA for rest storage access insns : EA ← ((RA=0) ? 0 : GPR[RA]) + GPR[RB]
>
> This is why I could not reuse that function. Also, this calculation of EA is 
> limited to these
> 4 insns above, and only 2 others (prefixed insns), which is why I did not create a new 
> function
> for this, considering it won't be reused for any other insn.
>
> Please let me know if I should create a new function in this case as well.

If you expect this to be used just once, then leaving it inline is perfectly 
fine.


r~