|
From: | Richard Henderson |
Subject: | Re: [PATCH 09/14] target/ppc: add helper to write per-LPAR SPRs |
Date: | Sat, 18 May 2024 13:26:22 +0200 |
User-agent: | Mozilla Thunderbird |
On 5/18/24 11:31, Nicholas Piggin wrote:
+void spr_core_write_generic32(DisasContext *ctx, int sprn, int gprn) +{ + TCGv t0 = tcg_temp_new(); + if (!(ctx->flags & POWERPC_FLAG_SMT)) { + spr_write_generic32(ctx, sprn, gprn); + return; + } + + if (!gen_serialize(ctx)) { + return; + } + + tcg_gen_ext32u_tl(t0, cpu_gpr[gprn]);
Better to delay allocating the temp until needed, so that you don't allocate one along the return paths.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |