Re: [PATCH 11/12] target/ppc: declare vmsumuhm helper with call flags

[Richard Henderson]

On 5/17/22 05:39, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
>
> Move vmsumuhm and vmsumuhs to decodetree, declare vmsumuhm helper with
> TCG_CALL_NO_RWG, and drop the unused env argument.
>
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
> ---
>   target/ppc/helper.h                 |  4 ++--
>   target/ppc/insn32.decode            |  2 ++
>   target/ppc/int_helper.c             |  5 ++---
>   target/ppc/translate/vmx-impl.c.inc | 24 ++++++++++++++++++++++--
>   target/ppc/translate/vmx-ops.c.inc  |  1 -
>   5 files changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/target/ppc/helper.h b/target/ppc/helper.h
> index f0761fe38d..5127851f2c 100644
> --- a/target/ppc/helper.h
> +++ b/target/ppc/helper.h
> @@ -242,8 +242,8 @@ DEF_HELPER_4(vpkudum, void, env, avr, avr, avr)
>   DEF_HELPER_FLAGS_3(vpkpx, TCG_CALL_NO_RWG, void, avr, avr, avr)
>   DEF_HELPER_5(vmhaddshs, void, env, avr, avr, avr, avr)
>   DEF_HELPER_5(vmhraddshs, void, env, avr, avr, avr, avr)
> -DEF_HELPER_5(vmsumuhm, void, env, avr, avr, avr, avr)
> -DEF_HELPER_5(vmsumuhs, void, env, avr, avr, avr, avr)
> +DEF_HELPER_FLAGS_4(VMSUMUHM, TCG_CALL_NO_RWG, void, avr, avr, avr, avr)
> +DEF_HELPER_5(VMSUMUHS, void, env, avr, avr, avr, avr)

Actually, you can set NO_RWG for the second as well, because the only thing from env that 
is modified is set_vscr_sat, which is not a TCG global.


r~