Re: [PATCH v4 20/22] target/ppc: Remove msr_de macro

[Richard Henderson]

On 5/4/22 16:05, Víctor Colombo wrote:
> msr_de macro hides the usage of env->msr, which is a bad
> behavior. Substitute it with FIELD_EX64 calls that explicitly use
> env->msr as a parameter.
>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Víctor Colombo<victor.colombo@eldorado.org.br>
>
> ---
>
> v4: Add this patch as an usage of msr_de was added in another patch
>      https://patchew.org/QEMU/20220421011729.1148727-1-bmeng.cn@gmail.com/
> Signed-off-by: Víctor Colombo<victor.colombo@eldorado.org.br>
> ---
>   target/ppc/cpu.h         | 3 +--
>   target/ppc/helper_regs.c | 4 ++--
>   2 files changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~