Re: [PATCH v2 13/21] target/ppc: Remove msr_me macro

[Richard Henderson]

On 5/2/22 14:38, Richard Henderson wrote:
> On 5/2/22 07:39, Víctor Colombo wrote:
> > msr_me macro hides the usage of env->msr, which is a bad behavior
> > Substitute it with FIELD_EX64 calls that explicitly use env->msr
> > as a parameter.
> >
> > Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> > Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
> >
> > ---
> >
> > v2: Remove M_MSR_CM and use FIELD_EX64 instead
> > Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
> > ---
> >   target/ppc/cpu.h        | 2 +-
> >   target/ppc/mmu_common.c | 2 +-
> >   target/ppc/mmu_helper.c | 2 +-
> >   3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> > index 294c61c9dc..8e652691cf 100644
> > --- a/target/ppc/cpu.h
> > +++ b/target/ppc/cpu.h
> > @@ -354,6 +354,7 @@ typedef enum {
> >   #define MSR_RI   1  /* Recoverable interrupt                        1        
> > */
> >   #define MSR_LE   0  /* Little-endian mode                           1 hflags 
> > */
> > +FIELD(MSR, CM, MSR_CM, 1)
>
> Patch title is wrong.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~