Re: [PATCH] target/ppc: Remove support for the PowerPC 602 CPU

[Cédric Le Goater]

> > diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> > index 66e13075c3df..b9119479958c 100644
> > --- a/target/ppc/cpu.h
> > +++ b/target/ppc/cpu.h
>
> In cpu.h you could probably remove the MSR_AP and MSR_SA bit definitions
> as well. And the code in ppc_cpu_reset that sets them.

done !

> > @@ -2142,8 +2142,6 @@ enum {
> >       PPC_MFTB           = 0x0000000000000200ULL,
> >   
> >       /* Fixed-point unit extensions                                           */
> > -    /*   PowerPC 602 specific                                                */
> > -    PPC_602_SPEC       = 0x0000000000000400ULL,
> >       /*   isel instruction                                                    
> > */
> >       PPC_ISEL           = 0x0000000000000800ULL,
> >       /*   popcntb instruction                                                 
> > */
>
> ...
>
> > diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c
> > index 9bc327bcba5a..d7765fd3e3d8 100644
> > --- a/target/ppc/int_helper.c
> > +++ b/target/ppc/int_helper.c
> > @@ -488,27 +488,6 @@ target_ulong helper_divso(CPUPPCState *env, target_ulong 
> > arg1,
> >       }
> >   }
> >   
> > -/*****************************************************************************/
> > -/* 602 specific instructions */
> > -/* mfrom is the most crazy instruction ever seen, imho ! */
>
> How do you have the heart to remove the "most crazy instruction ever
> seen"?

It is indeed crazy and QEMU is the perfect playground to implement
instructions even more crazier but I am without heart for this one :)

Cheers,

C.