Re: [PATCH 0/8] target/ppc: powerpc_excp improvements [74xx] (5/n)

[Cédric Le Goater]

On 1/27/22 16:16, Fabiano Rosas wrote:
> Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> writes:
>
> > On 26/01/2022 16:41, Fabiano Rosas wrote:
> >
> > > This handles the exception code for the 74xx family, i.e. 7400, 7410,
> > > 7440, 7445, 7450, 7455, 7457.
> > >
> > > This is another family that is quite well known, so it should be
> > > straight-forward as well.
> > >
> > > Based on legoater/ppc-7.0
> > >
> > > Fabiano Rosas (8):
> > >     target/ppc: Introduce powerpc_excp_74xx
> > >     target/ppc: Simplify powerpc_excp_74xx
> > >     target/ppc: 74xx: Machine Check exception cleanup
> > >     target/ppc: 74xx: External interrupt cleanup
> > >     target/ppc: 74xx: Program exception cleanup
> > >     target/ppc: 74xx: System Call exception cleanup
> > >     target/ppc: 74xx: System Reset interrupt cleanup
> > >     target/ppc: 74xx: Set SRRs directly in exception code
> > >
> > >    target/ppc/excp_helper.c | 175 +++++++++++++++++++++++++++++++++++++++
> > >    1 file changed, 175 insertions(+)
> >
> > I'm not overly familiar with PPC exception handling detail, so I can't offer 
> > much in
> > the way of review I'm afraid. I could do a quick test and make sure nothing 
> > breaks
> > with my MacOS images though?
>
> Sure, no problem. This is more of an FYI and so you know whom to yell at
> in case anything breaks for you.

yes ! Thanks,

> I have some MacOS images I can use to test as well. I'll do a thorough
> pass before sending the v2.
>
> > Also any thoughts on Christophe's question re: e300 PVRs at
> > https://lists.gnu.org/archive/html/qemu-ppc/2022-01/msg00592.html? I can handle
> > merging the OpenBIOS changes if someone can come up with a suitable fix.

Why not simply extend 'struct cpudef' with a flag/feature field ?

> I believe Cédric has been looking at the 60x, maybe he has some
> input. 

yes. 604 is running fine under the 40p machine with OpenBIOS.
I have an old debian 3 disk image for it.

On the same machine, AIX 4x and 5x also run with this firmware :

  
http://github.com/artyom-tarasenko/openfirmware/releases/download/40p-20190413/q40pofw-serial.rom

and the g3beige supports 604.

Getting a status on 603 is more complex. We need support for the
6xx SoftTLBs in OpenBIOS to move forward. Christophe and I have
spent some time on this. Work in progress.

602 should be removed IMHO. It has no real value.

601 is a transitional processor. It think it should be good to
keep as a reference. I don't have a workload for it though.

> We currently can only run the 604 if I'm not mistaken, so there's
> some work to be done to bring all of the 60x back to life. The e300 will
> be in the mix.

It should yes. I haven't looked at it yet.

Thanks,

C.