Re: [PATCH v2 5/8] ppc/pnv: remove PnvPhb4PecStack::stack_no

[Cédric Le Goater]

On 1/14/22 19:07, Daniel Henrique Barboza wrote:
> pnv_pec_default_phb_realize() stopped using it after the previous patch and
> no one else is using it.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> ---
>   hw/pci-host/pnv_phb4_pec.c     | 2 --
>   include/hw/pci-host/pnv_phb4.h | 3 ---
>   2 files changed, 5 deletions(-)
>
> diff --git a/hw/pci-host/pnv_phb4_pec.c b/hw/pci-host/pnv_phb4_pec.c
> index a80a21db77..d6405d6ca3 100644
> --- a/hw/pci-host/pnv_phb4_pec.c
> +++ b/hw/pci-host/pnv_phb4_pec.c
> @@ -166,7 +166,6 @@ static void pnv_pec_realize(DeviceState *dev, Error **errp)
>           PnvPhb4PecStack *stack = &pec->stacks[i];
>           Object *stk_obj = OBJECT(stack);
>   
> -        object_property_set_int(stk_obj, "stack-no", i, &error_abort);
>           object_property_set_link(stk_obj, "pec", OBJECT(pec), &error_abort);
>   
>           if (defaults_enabled()) {
> @@ -314,7 +313,6 @@ static void pnv_pec_stk_realize(DeviceState *dev, Error 
> **errp)
>   }
>   
>   static Property pnv_pec_stk_properties[] = {
> -        DEFINE_PROP_UINT32("stack-no", PnvPhb4PecStack, stack_no, 0),
>           DEFINE_PROP_LINK("pec", PnvPhb4PecStack, pec, TYPE_PNV_PHB4_PEC,
>                            PnvPhb4PecState *),
>           DEFINE_PROP_END_OF_LIST(),
> diff --git a/include/hw/pci-host/pnv_phb4.h b/include/hw/pci-host/pnv_phb4.h
> index a9059b7279..2be56b7afd 100644
> --- a/include/hw/pci-host/pnv_phb4.h
> +++ b/include/hw/pci-host/pnv_phb4.h
> @@ -171,9 +171,6 @@ OBJECT_DECLARE_SIMPLE_TYPE(PnvPhb4PecStack, 
> PNV_PHB4_PEC_STACK)
>   struct PnvPhb4PecStack {
>       DeviceState parent;
>   
> -    /* My own stack number */
> -    uint32_t stack_no;
> -
>       /* The owner PEC */
>       PnvPhb4PecState *pec;
>