[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/8] target/ppc: 405: System call exception cleanup
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH 8/8] target/ppc: 405: System call exception cleanup |
|
Date: |
Tue, 11 Jan 2022 09:48:50 -0300 |
David Gibson <david@gibson.dropbear.id.au> writes:
> On Mon, Jan 10, 2022 at 03:15:46PM -0300, Fabiano Rosas wrote:
>> There's no sc 1.
>>
>> We also only used env->nip because of the vhyp code, so change to
>> 'vector' now.
>
> I don't think this is right. The point with the env->nip change is
> changing the PC as it appeared *before* saving it to SRR0, so that
> we'll eventually return to the right place. 'vector' is the address
> for the interrupt vector itself.
Ugh, In the RFC version I introduced a 'nip' that holds env->nip. So it
would be correct to use 'nip' instead of 'env->nip' here. I knew
'vector' was looking off... Thanks for catching that.
- [PATCH 5/8] target/ppc: 405: Critical exceptions cleanup, (continued)
- [PATCH 5/8] target/ppc: 405: Critical exceptions cleanup, Fabiano Rosas, 2022/01/10
- [PATCH 7/8] target/ppc: 405: External exception cleanup, Fabiano Rosas, 2022/01/10
- [PATCH 3/8] target/ppc: Introduce powerpc_excp_40x, Fabiano Rosas, 2022/01/10
- [PATCH 6/8] target/ppc: 405: Machine check exception cleanup, Fabiano Rosas, 2022/01/10
- [PATCH 8/8] target/ppc: 405: System call exception cleanup, Fabiano Rosas, 2022/01/10
- Re: [PATCH 0/8] target/ppc: powerpc_excp improvements [40x] (3/n), Cédric Le Goater, 2022/01/11