[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/19] host-utils: Fix overflow detection in divu128()
From: |
Luis Pires |
Subject: |
[PATCH v2 01/19] host-utils: Fix overflow detection in divu128() |
Date: |
Tue, 31 Aug 2021 13:39:49 -0300 |
The previous code didn't detect overflows if the high 64-bit
of the dividend were equal to the 64-bit divisor. In that case,
64 bits wouldn't be enough to hold the quotient.
Signed-off-by: Luis Pires <luis.pires@eldorado.org.br>
---
util/host-utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/host-utils.c b/util/host-utils.c
index 7b9322071d..a789a11b46 100644
--- a/util/host-utils.c
+++ b/util/host-utils.c
@@ -102,7 +102,7 @@ int divu128(uint64_t *plow, uint64_t *phigh, uint64_t
divisor)
*plow = dlo / divisor;
*phigh = dlo % divisor;
return 0;
- } else if (dhi > divisor) {
+ } else if (dhi >= divisor) {
return 1;
} else {
--
2.25.1
- [PATCH v2 00/19] target/ppc: DFP instructions using decodetree, Luis Pires, 2021/08/31
- [PATCH v2 01/19] host-utils: Fix overflow detection in divu128(),
Luis Pires <=
- [PATCH v2 02/19] host-utils: move abs64() to host-utils as uabs64(), Luis Pires, 2021/08/31
- [PATCH v2 03/19] host-utils: move checks out of divu128/divs128, Luis Pires, 2021/08/31
- [PATCH v2 04/19] host-utils: add 128-bit quotient support to divu128/divs128, Luis Pires, 2021/08/31
- [PATCH v2 05/19] host-utils: add unit tests for divu128/divs128, Luis Pires, 2021/08/31
- [PATCH v2 06/19] libdecnumber: introduce decNumberFrom[U]Int128, Luis Pires, 2021/08/31