Re: [PATCH 06/26] ppc/pnv: add a chip topology index for POWER10

[Cédric Le Goater]

On 8/20/21 4:12 PM, Greg Kurz wrote:
> On Mon, 9 Aug 2021 15:45:27 +0200
> Cédric Le Goater <clg@kaod.org> wrote:
> 
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> 
> Maybe add a short description of its purpose in the changelog
> for the records ? What's the difference with "ibm,chip-id" ?


yep. I will add a comment.

Thanks,

C. 

>> ---
>>  hw/ppc/pnv_xscom.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/ppc/pnv_xscom.c b/hw/ppc/pnv_xscom.c
>> index be7018e8ac59..faa488e3117a 100644
>> --- a/hw/ppc/pnv_xscom.c
>> +++ b/hw/ppc/pnv_xscom.c
>> @@ -284,6 +284,8 @@ int pnv_dt_xscom(PnvChip *chip, void *fdt, int 
>> root_offset,
>>      _FDT(xscom_offset);
>>      g_free(name);
>>      _FDT((fdt_setprop_cell(fdt, xscom_offset, "ibm,chip-id", 
>> chip->chip_id)));
>> +    _FDT((fdt_setprop_cell(fdt, xscom_offset, "ibm,primary-topology-index",
>> +                           chip->chip_id)));
>>      _FDT((fdt_setprop_cell(fdt, xscom_offset, "#address-cells", 1)));
>>      _FDT((fdt_setprop_cell(fdt, xscom_offset, "#size-cells", 1)));
>>      _FDT((fdt_setprop(fdt, xscom_offset, "reg", reg, sizeof(reg))));
>