[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 02/10] hw/mos6522: Remove get_counter_value() methods and funct
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC 02/10] hw/mos6522: Remove get_counter_value() methods and functions |
Date: |
Tue, 24 Aug 2021 12:29:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/24/21 12:09 PM, Finn Thain wrote:
> This code appears to be unnecessary.
>
> Also, these routines don't return the counter value but a time interval
> between counter values, so they are misnamed.
>
> Signed-off-by: Finn Thain <fthain@linux-m68k.org>
> ---
> hw/misc/mos6522.c | 22 ++--------------------
> 1 file changed, 2 insertions(+), 20 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [RFC 05/10] hw/mos6522: Don't clear T1 interrupt flag on latch write, (continued)
- [RFC 07/10] hw/mos6522: Fix initial timer counter reload, Finn Thain, 2021/08/24
- [RFC 03/10] hw/mos6522: Remove redundant mos6522_timer1_update() calls, Finn Thain, 2021/08/24
- [RFC 10/10] hw/mos6522: Synchronize timer interrupt and timer counter, Finn Thain, 2021/08/24
- [RFC 02/10] hw/mos6522: Remove get_counter_value() methods and functions, Finn Thain, 2021/08/24
- Re: [RFC 02/10] hw/mos6522: Remove get_counter_value() methods and functions,
Philippe Mathieu-Daudé <=
- [RFC 06/10] hw/mos6522: Implement oneshot mode, Finn Thain, 2021/08/24
- [RFC 09/10] hw/mos6522: Avoid using discrepant QEMU clock values, Finn Thain, 2021/08/24
- Re: [RFC 00/10] hw/mos6522: VIA timer emulation fixes and improvements, David Gibson, 2021/08/25
- Re: [RFC 00/10] hw/mos6522: VIA timer emulation fixes and improvements, Mark Cave-Ayland, 2021/08/25