[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc
From: |
Greg Kurz |
Subject: |
Re: [PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc |
Date: |
Fri, 16 Jul 2021 14:47:57 +0200 |
On Mon, 12 Jul 2021 16:43:36 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
> Clarify that @device is optional and that 'path' is the device
> path from QOM.
>
> This change follows Markus' suggestion verbatim, provided in full
> context here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg01891.html
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> qapi/qdev.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/qdev.json b/qapi/qdev.json
> index b83178220b..d1d3681a50 100644
> --- a/qapi/qdev.json
> +++ b/qapi/qdev.json
> @@ -108,9 +108,9 @@
> # At this point, it's safe to reuse the specified device ID. Device removal
> can
> # be initiated by the guest or by HMP/QMP commands.
> #
> -# @device: device name
> +# @device: the device's ID if it has one
> #
> -# @path: device path
> +# @path: the device's path within the object model
> #
> # Since: 1.5
> #
- [PATCH v5 0/7] DEVICE_UNPLUG_ERROR QAPI event, Daniel Henrique Barboza, 2021/07/12
- [PATCH v5 1/7] hw/acpi/memory_hotplug.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL, Daniel Henrique Barboza, 2021/07/12
- [PATCH v5 2/7] spapr.c: avoid sending MEM_UNPLUG_ERROR if dev->id is NULL, Daniel Henrique Barboza, 2021/07/12
- [PATCH v5 3/7] spapr_drc.c: do not error_report() when drc->dev->id == NULL, Daniel Henrique Barboza, 2021/07/12
- [PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc, Daniel Henrique Barboza, 2021/07/12
- Re: [PATCH v5 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc,
Greg Kurz <=
- [PATCH v5 5/7] qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event, Daniel Henrique Barboza, 2021/07/12
- [PATCH v5 6/7] spapr: use DEVICE_UNPLUG_ERROR to report unplug errors, Daniel Henrique Barboza, 2021/07/12
- [PATCH v5 7/7] memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write(), Daniel Henrique Barboza, 2021/07/12