Re: [PATCH 2/3] target/ppc: Fix compilation with FLUSH_ALL_TLBS debug option

[David Gibson]

On Fri, Jul 02, 2021 at 06:52:34PM -0300, Fabiano Rosas wrote:
> ../target/ppc/mmu_helper.c: In function 'helper_store_ibatu':
> ../target/ppc/mmu_helper.c:1802:17: error: unused variable 'cpu' 
> [-Werror=unused-variable]
>  1802 |     PowerPCCPU *cpu = env_archcpu(env);
>       |                 ^~~
> ../target/ppc/mmu_helper.c: In function 'helper_store_dbatu':
> ../target/ppc/mmu_helper.c:1838:17: error: unused variable 'cpu' 
> [-Werror=unused-variable]
>  1838 |     PowerPCCPU *cpu = env_archcpu(env);
>       |                 ^~~
> ../target/ppc/mmu_helper.c: In function 'helper_store_601_batu':
> ../target/ppc/mmu_helper.c:1874:17: error: unused variable 'cpu' 
> [-Werror=unused-variable]
>  1874 |     PowerPCCPU *cpu = env_archcpu(env);
>       |                 ^~~
> ../target/ppc/mmu_helper.c: In function 'helper_store_601_batl':
> ../target/ppc/mmu_helper.c:1919:17: error: unused variable 'cpu' 
> [-Werror=unused-variable]
>  1919 |     PowerPCCPU *cpu = env_archcpu(env);
> 
> Fixes: db70b31144 ("target/ppc: Use env_cpu, env_archcpu")
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>

Applied to ppc-for-6.1, thanks.

> ---
>  target/ppc/mmu_helper.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
> index ff2c6bdd8c..67caba6369 100644
> --- a/target/ppc/mmu_helper.c
> +++ b/target/ppc/mmu_helper.c
> @@ -1798,9 +1798,6 @@ static inline void dump_store_bat(CPUPPCState *env, 
> char ID, int ul, int nr,
>  void helper_store_ibatu(CPUPPCState *env, uint32_t nr, target_ulong value)
>  {
>      target_ulong mask;
> -#if defined(FLUSH_ALL_TLBS)
> -    PowerPCCPU *cpu = env_archcpu(env);
> -#endif
>  
>      dump_store_bat(env, 'I', 0, nr, value);
>      if (env->IBAT[0][nr] != value) {
> @@ -1834,9 +1831,6 @@ void helper_store_ibatl(CPUPPCState *env, uint32_t nr, 
> target_ulong value)
>  void helper_store_dbatu(CPUPPCState *env, uint32_t nr, target_ulong value)
>  {
>      target_ulong mask;
> -#if defined(FLUSH_ALL_TLBS)
> -    PowerPCCPU *cpu = env_archcpu(env);
> -#endif
>  
>      dump_store_bat(env, 'D', 0, nr, value);
>      if (env->DBAT[0][nr] != value) {
> @@ -1871,7 +1865,6 @@ void helper_store_601_batu(CPUPPCState *env, uint32_t 
> nr, target_ulong value)
>  {
>      target_ulong mask;
>  #if defined(FLUSH_ALL_TLBS)
> -    PowerPCCPU *cpu = env_archcpu(env);
>      int do_inval;
>  #endif
>  
> @@ -1916,7 +1909,6 @@ void helper_store_601_batl(CPUPPCState *env, uint32_t 
> nr, target_ulong value)
>  #if !defined(FLUSH_ALL_TLBS)
>      target_ulong mask;
>  #else
> -    PowerPCCPU *cpu = env_archcpu(env);
>      int do_inval;
>  #endif
>  

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature