Re: [PATCH 0/5] stop collection of instruction usage statistics

[Alex Bennée]

"Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br> writes:

> Based-on: <20210525115355.8254-1-bruno.larsen@eldorado.org.br>
>
> The functionality of counting how many instructions were being executed and
> being able to show it through the monitor, although neat, was only
> supported by ppc, and now that it is migrating to use decodetree (at
> least partially), those statistics won't be used anymore. Therefore,
> this patch removes that functinality completely.

I have no particular comment to make about the PPC stuff but with the
common translator loop we have hooks across all converted front ends to
identify the start of each instruction. It's needed for the TCG plugin
instrumentation and we could in theory use it for more integrated stats
across the board.

Out of interest what was the main aim of this code - a view of total
executed instructions or something more detailed like a breakdown of
types and ops?

>
> This series was suggested by Richard Henderson
>
> Bruno Larsen (billionai) (5):
>   target/ppc: fixed GEN_OPCODE behavior when PPC_DUMP_CPU is set
>   target/ppc: remove ppc_cpu_dump_statistics
>   target/ppc: removed mentions to DO_PPC_STATISTICS
>   monitor: removed cpustats command
>   hw/core/cpu: removed cpu_dump_statistics function
>
>  hmp-commands-info.hx   | 13 --------
>  hw/core/cpu.c          |  9 ------
>  include/hw/core/cpu.h  | 12 --------
>  monitor/misc.c         | 11 -------
>  target/ppc/cpu.h       |  1 -
>  target/ppc/cpu_init.c  |  3 --
>  target/ppc/translate.c | 69 +++---------------------------------------
>  7 files changed, 5 insertions(+), 113 deletions(-)


-- 
Alex Bennée