qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fps


From: Richard Henderson
Subject: Re: [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr
Date: Mon, 24 May 2021 19:01:20 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/21/21 1:17 PM, Bruno Larsen (billionai) wrote:
+    uint32_t mask = 1u << bit;
+    if (env->fpscr & mask) {
+        ppc_store_fpscr(env, env->fpscr & ~mask);

Oops, missed this during review but:

  fpscr & ~(target_ulong)mask;

Otherwise we clear high bits of fpscr incorrectly.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]